feat(export): Add client for /export endpoint#574
Open
bevzzz wants to merge 3 commits into
Open
Conversation
Bump 1.37 version to the latest v1.37.7
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
dirkkul
approved these changes
Jun 9, 2026
| /** Path to export in the backend storage. */ | ||
| @SerializedName("path") String path, | ||
| /** Export storage backend. */ | ||
| @SerializedName("backend") String backend, |
Collaborator
There was a problem hiding this comment.
should we type this? We have four backends and will not add new ones in the forseeable future
| * due to a malformed request, a networking error | ||
| * or the server being unavailable. | ||
| */ | ||
| public Export create(String exportId, String backend) throws IOException { |
Collaborator
There was a problem hiding this comment.
Should we have the backend as an Enum? There are only four valid values and those dont change often
| * or the server being unavailable. | ||
| */ | ||
| public Export create(String exportId, String backend) throws IOException { | ||
| return create(new CreateExportRequest(CreateExportRequest.ExportCreate.of(exportId), backend)); |
Collaborator
There was a problem hiding this comment.
I would also add the file format as a required parameter. There is currently only one, but there was strong interest in adding more
| * due to a malformed request, a networking error | ||
| * or the server being unavailable. | ||
| */ | ||
| public Export create(CreateExportRequest request) throws IOException { |
Collaborator
There was a problem hiding this comment.
Maybe its a Java thing but this overload seems to be a bit too much? :)
| return "/export/" + cancel.backend + "/" + cancel.exportId; | ||
| }, | ||
| request -> Collections.emptyMap()) | ||
| .allowStatus(409); |
| return excludeCollections(Arrays.asList(excludeCollections)); | ||
| } | ||
|
|
||
| /** Collection that should be excluded from the backup. */ |
Collaborator
There was a problem hiding this comment.
comments say backup in this file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modeled after the export API in the Python client,
client.exportnamespace exports methods to create, check status, and cancel a collection export. To the user working with export API should feel the same as working with the backups.Bumped 1.37 version for integration tests to the latest patch, v1.37.7.